Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert resolve nested dependencies #3753 #4019

Merged
merged 1 commit into from
Jun 29, 2021
Merged

fix: revert resolve nested dependencies #3753 #4019

merged 1 commit into from
Jun 29, 2021

Conversation

patak-dev
Copy link
Member

Fixes #4005

Description

Revert #3753, as discussed with @Yelmor.

I only reverted the code change in packages/vite/src/node/optimizer/esbuildDepPlugin.ts, and left the test suite with a TODO: until #3573 is reworked to fix #3254 again.

Additional context

Tested that #4005 is working correctly after this PR
Probably also fixes #4012 and #4014, I'll ask them to test once this is merged


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev requested a review from antfu June 29, 2021 12:05
@antfu
Copy link
Member

antfu commented Jun 29, 2021

Do we want to make a hotfix after this?

@patak-dev
Copy link
Member Author

Yelmor said it doesn't look like an easy fix. I think we need to leave it for 2.4.x, when a proper solution is found

@antfu
Copy link
Member

antfu commented Jun 29, 2021

Yeah I mean hotfix release 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants